Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide .deb packages #697

Open
1 task done
ilovethensa opened this issue Mar 27, 2024 · 8 comments
Open
1 task done

Provide .deb packages #697

ilovethensa opened this issue Mar 27, 2024 · 8 comments

Comments

@ilovethensa
Copy link

Description

Would make installing on docker-less environments way easier

Desired Behavior

Provided .deb files

Additional Context

No response

Code of Conduct

  • I agree to follow Jellyseerr's Code of Conduct
@joshuaboniface
Copy link
Contributor

Agreed, willing to take this on.

@joshuaboniface
Copy link
Contributor

So, Debian packaging here is going to be quite difficult to do "properly", as splitting the various parts out into Debianlized folders seems to be impossible.

I can do a hacky alternative though of putting everything under /opt/jellyseerr, which isn't quite as nice (and wouldn't be accepted to an upstream) but will work for now.

@Fallenbagel
Copy link
Owner

So, Debian packaging here is going to be quite difficult to do "properly", as splitting the various parts out into Debianlized folders seems to be impossible.

I can do a hacky alternative though of putting everything under /opt/jellyseerr, which isn't quite as nice (and wouldn't be accepted to an upstream) but will work for now.

How about something similar to the AUR package? Is that doable? Where the config folder is symlinked?
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=jellyseerr#n60

@joshuaboniface
Copy link
Contributor

That is possible, but I don't think it's good practice to do so.

@joshuaboniface
Copy link
Contributor

The other issue would be packaging the node_modules in the .deb which makes it huge. I'm trying to see if there's a way around that but I'll need to do some more reading into how to properly package NodeJS projects in Debian.

@joshuaboniface
Copy link
Contributor

joshuaboniface commented Apr 12, 2024

Just for context: the big difference between a .deb and the AUR is that AUR packages are built on the client machine at install, while .debs are built remotely and the full binaries are sent. This is running into problems with node_modules because it tries to do a lot of .deb magic on them and fails. So there has to be a better way here, but I'm also thinking that this might not be entirely possible, at least not in a clean way that won't result in a 1.6+GB(!) .deb.

@Fallenbagel
Copy link
Owner

Just for context: the big difference between a .deb and the AUR is that AUR packages are built on the client machine at install, while .debs are built remotely and the full binaries are sent. This is running into problems with node_modules because it tries to do a lot of .deb magic on them and fails. So there has to be a better way here, but I'm also thinking that this might not be entirely possible, at least not in a clean way that won't result in a 1.6+GB(!) .deb.

I guess at that point and install script would be better then? 🤔

@joshuaboniface
Copy link
Contributor

I've done some more digging, and for simple NodeJS projects, https://github.com/heartsucker/node-deb seems like a good solution. But from what I've seen of it Overseerr (and hence Jellyseerr) is not simple. Most of all, the fact that the node_modules dir is over 1.6GB pretty much precludes making a sensible .deb here, as that entire thing needs to be included. We just don't have the AUR benefit of running things like yarn build at install time.

So I definitely think an installer script is the better bet here.

@joshuaboniface joshuaboniface removed their assignment Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants