Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark up look strange on the site when using pipes | #5176

Open
computamike opened this issue Nov 20, 2020 · 10 comments · Fixed by #6723
Open

Mark up look strange on the site when using pipes | #5176

computamike opened this issue Nov 20, 2020 · 10 comments · Fixed by #6723
Assignees
@computamike @vhf
Labels
🐛 BUG Confirmed bugs, normally at GitHub Pages conflicts Conflict(s) need to be resolved keep Requests exempt from being punctually stale PR requested Issues that can be addressed with a new PR waiting for changes PR has been reviewed and changes/suggestions requested

Comments

@computamike
Copy link
Contributor

It seems that the | in the link breaks the rendering
C#

Renders correctly when viewing the page within GitHub editing tools, but renders incorrectly on the GH Pages site.
@eshellman
Copy link
Collaborator

not surprising I guess. Want to fix it?

@eshellman eshellman added the PR requested Issues that can be addressed with a new PR label Nov 21, 2020
@computamike
Copy link
Contributor Author

hi @eshellman - I'm looking into it now...

computamike added a commit to computamike/free-programming-books that referenced this issue Nov 21, 2020
@computamike
Fixing issue EbookFoundation#5176
9996b29
This was referenced Nov 21, 2020
Merged
Open
eshellman pushed a commit that referenced this issue Nov 21, 2020
@computamike
Fixing issue #5176 (#5177)
fb36239
@computamike
Copy link
Contributor Author

For more information - I have developed a linter plugin for this issue, just trying to figure out how to contribute it.

https://github.com/computamike/remark-link-escape

Do I close this issue, or is that something that the team needs to do?

@eshellman
Copy link
Collaborator

eshellman commented Nov 23, 2020 •
edited

Let's leave it open; hopefully it will be addressed together with #5031

tt512 pushed a commit to tt512/free-programming-books that referenced this issue May 7, 2021
@computamike @tt512
Fixing issue EbookFoundation#5176 (EbookFoundation#5177)
e277a5b
@davorpa
Copy link
Member

davorpa commented Jul 31, 2021 •
edited

Hi team

Although the nice @computamike's plugin was added as dependency in v2.2.0, this improvement was reverted in 2.3.0 (2020 Dec)

vhf/free-programming-books-lint@v2.2.0...v2.3.0

@vhf CI action is now using last released version (v3.0.0) with last alphabetize requested features #5031 but not with vhf/free-programming-books-lint#12

CI logs: https://github.com/EbookFoundation/free-programming-books/runs/3195091515?check_suite_focus=true#step:4:8 (see install lint step)

I don't know what is their status because I'm newbie, but it would be a nice point to reintegrate again before it rots into oblivion, I thought @eshellman 🤗

/labelthis: resummit pr

@davorpa davorpa mentioned this issue Sep 27, 2021
Closed
@charlottetan

This comment was marked as outdated.

Sign in to view
@davorpa davorpa added conflicts Conflict(s) need to be resolved waiting for changes PR has been reviewed and changes/suggestions requested labels Oct 3, 2021
@davorpa
Copy link
Member

davorpa commented Oct 3, 2021

Took me awhile to find the relevant page: https://ebookfoundation.github.io/free-programming-books/casts/free-podcasts-screencasts-en.html

Appears to be rendering fine now

We know it. See the fix #5177. The vertical bar is escaped

@charlottetan
Copy link
Contributor

charlottetan commented Oct 3, 2021 •
edited

Oh nice thanks! What is the remaining work on this issue? Did you want to close this issue?

This was referenced Oct 5, 2021
Merged
Closed
Merged
@EbookFoundation EbookFoundation locked as too heated and limited conversation to collaborators Jan 29, 2022
@davorpa
Copy link
Member

davorpa commented Feb 11, 2022 •
edited

It also happens in Arabic courses file #6715

Environment Screenshot
Github File Preview 👍 image
GitHub Pages 👎 image image

Is wellknown that pipes is the table markdown token. Seems that Kramdown don't deal well with it

@davorpa davorpa reopened this Feb 11, 2022
@davorpa davorpa added 🐛 BUG Confirmed bugs, normally at GitHub Pages and removed waiting for changes PR has been reviewed and changes/suggestions requested labels Feb 11, 2022
@davorpa davorpa changed the title Screen cast mark up look strange on the site Mark up look strange on the site Feb 11, 2022
@davorpa davorpa changed the title Mark up look strange on the site Mark up look strange on the site when using pipes | Feb 11, 2022
@davorpa davorpa linked a pull request Feb 14, 2022 that will close this issue
fix: Escape pipes. It makes wrong render as tables in Kramdown/GFM engines #6723
Merged
2 tasks
@davorpa davorpa reopened this Feb 14, 2022
@davorpa
Copy link
Member

davorpa commented Feb 14, 2022 •
edited

Needs linter replug in to definitelly solve it. See #5176 (comment)

Notified to kramdown engine at kramdown/parser-gfm#35

@davorpa davorpa added the waiting for changes PR has been reviewed and changes/suggestions requested label Feb 14, 2022
@davorpa davorpa added the keep Requests exempt from being punctually stale label Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@computamike computamike

@vhf vhf

Labels
🐛 BUG Confirmed bugs, normally at GitHub Pages conflicts Conflict(s) need to be resolved keep Requests exempt from being punctually stale PR requested Issues that can be addressed with a new PR waiting for changes PR has been reviewed and changes/suggestions requested
Projects
None yet
Milestone
No milestone
6 participants
@computamike @eshellman @vhf @davorpa @charlottetan @LuigiImVector