Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add replacement placeholder for Quora #2825

Closed
wants to merge 1 commit into from
Closed

Add replacement placeholder for Quora #2825

wants to merge 1 commit into from

Conversation

clasick
Copy link

@clasick clasick commented Jan 2, 2022

Fixes #2824.

Preview:

@ghostwords
Copy link
Member

Thank you for the pull request!

Do you have examples of other sites using the Quora widget? I haven't seen any in Privacy Badger user error reports. I would rather not add a widget for something that isn't widely used.

@ghostwords ghostwords added the widgets Click-to-activate placeholders for blocked but potentially useful social buttons/widgets label Jan 4, 2022
@clasick
Copy link
Author

clasick commented Jan 4, 2022

@ghostwords Not sure, I just added it based on #2824. So we know Medium definitely has one, maybe the issue creator @shreshth3142857 might know about more.

@ghostwords
Copy link
Member

OK, let's hold off on adding a Quora widget placeholder for now.

@ghostwords ghostwords closed this Oct 12, 2023
@shreshth65968
Copy link

shreshth65968 commented Oct 13, 2023 •
edited

@ghostwords Not sure, I just added it based on #2824. So we know Medium definitely has one, maybe the issue creator @shreshth3142857 might know about more.

hey , at that time there was issue with the placeholder , I was an avid quora user, if you havent received much reports about this issue, then its fine, :), how come this issue come again? it was like year ago?

@ghostwords
Copy link
Member

ghostwords commented Oct 13, 2023 •
edited

how come this issue come again?

Just periodically pruning issues and pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
widgets Click-to-activate placeholders for blocked but potentially useful social buttons/widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaks Quora embeds
3 participants
@clasick @ghostwords @shreshth65968