Impossible to delete Draft Invoice because of delete_linked_contact empty

[JphenixB]

Bug

Error when trying to delete a draft invoice.

In facture.class.php line 2871 the if do 3 tests at the same time that all need to be true :

1. $this->db->query($sqlef)
2. $this->db->query($sql)
3. $this->delete_linked_contact()

In delete_linked_contact from the object CommonObject, the result can be :
Return integer <0 if KO, 0=Nothing done, >0 if OK

The ligne :
if ($this->db->query($sqlef) && $this->db->query($sql) && $this->delete_linked_contact()) {
Have to be change by:
if ($this->db->query($sqlef) && $this->db->query($sql) && $this->delete_linked_contact()>=0) {

Dolibarr Version

19.0.2

Environment PHP

8.2.5

Environment Database

MySQL or MariaDB 10.11.2-MariaDB

Steps to reproduce the behavior and expected behavior

Create a draft invoice.
Try do delete It.

Attached files

No response