Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for direct ingestion of signed PCM sound directly into the bot's voice. #998

Open
MwenDavo opened this issue Sep 1, 2021 · 2 comments
Labels
area/voice Related to the voice module feature-request Request for a new library feature or behavior
Milestone

Comments

@MwenDavo
Copy link

MwenDavo commented Sep 1, 2021

Feature Description: I'm currently working on a bot that uses a signed PCM stream and outputs it to my bot voice. I'm using lavaplayer to achieve this, but I can't find a way to properly play songs through this. It'd be nice if the library had native support for this format, allowing to write the byte[], offset and size directly to the voice output.

Justification: Even though I'm requesting this for my bot, many other services, such as TTS applications, use this kind of format, so adding support for it would help integrate those services easily into Discord4J.

@darichey darichey added area/voice Related to the voice module feature-request Request for a new library feature or behavior labels Sep 7, 2021
@darichey
Copy link
Member

darichey commented Sep 7, 2021

The main problem with this is it necessitates shipping opus binaries.

@quanticc quanticc added this to the Backlog milestone Sep 7, 2021
@MwenDavo
Copy link
Author

MwenDavo commented Sep 10, 2021

Can't the opus binaries be pre-defined while initializing the library? I've seen this done in Lavaplayer, where you specify the standard and the rest is done automatically.
I'm having lots of problem trying to write my song stream directly to lavaplayer and then to discord4j. Due to how lavaplayer works, it could be skipped in my case (at least theoretically, I don't know technical details of how discord4j recieves the data and outputs it). I'm trying to avoid doing my own classes because I don't have that much experience in this kind of things.
Do you know any other alternative?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/voice Related to the voice module feature-request Request for a new library feature or behavior
Projects
None yet
Development

No branches or pull requests

3 participants