Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI artifacts lack licenses for libraries #295

Closed
Jayman2000 opened this issue May 6, 2024 · 2 comments · Fixed by #301
Closed

CI artifacts lack licenses for libraries #295

Jayman2000 opened this issue May 6, 2024 · 2 comments · Fixed by #301
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@Jayman2000
Copy link
Contributor

Descent 3 links to several open-source libraries. At the moment, Descent 3’s CI artifacts don’t comply with those libraries’s licenses. Specifically, they require that you include a copy of the license when distributing the libraries. At the moment, CI artifacts are missing licenses for the following:

Name Inclusion point License
libacm AudioEncode/CMakeLists.txt:6 Link
spdlog misc/CMakeLists.txt:12 Link
RSA Data Security, Inc. MD5 Message-Digest Algorithm Descent3/CMakeLists.txt:304 Link
@JeodC
Copy link
Collaborator

JeodC commented May 6, 2024

This should be considered "in progress".

@JeodC JeodC added the documentation Improvements or additions to documentation label May 6, 2024
@JeodC JeodC added this to the 1.5 Stable milestone May 6, 2024
Jayman2000 added a commit to Jayman2000/Descent3-pr that referenced this issue May 7, 2024
Jayman2000 added a commit to Jayman2000/Descent3-pr that referenced this issue May 7, 2024
Jayman2000 added a commit to Jayman2000/Descent3-pr that referenced this issue May 7, 2024
Jayman2000 added a commit to Jayman2000/Descent3-pr that referenced this issue May 7, 2024
Jayman2000 added a commit to Jayman2000/Descent3-pr that referenced this issue May 8, 2024
Specifically, this commit only adds copies of licenses if we are
required to do so. For example, this commit adds a copy of libacm’s
license because libacm’s license requires that we include copies of
libacm’s license with binary copies of libacm. This commit does not add
a copy of zlib’s license because zlib’s license doesn’t require us to do
so.

Fixes DescentDevelopers#295.
@JeodC
Copy link
Collaborator

JeodC commented May 17, 2024

This should be considered "in progress".

  • libacm can be included
  • spdlog is now the header only which may have a different license format
  • RSA MD5 has been changed so the license is no longer applicable
  • libmve will be GPLv2

Jayman2000 added a commit to Jayman2000/Descent3-pr that referenced this issue May 17, 2024
Specifically, this commit only adds copies of licenses if we are
required to do so. For example, this commit adds a copy of libacm’s
license because libacm’s license requires that we include copies of
libacm’s license with binary copies of libacm. This commit does not add
a copy of zlib’s license because zlib’s license doesn’t require us to do
so.

Fixes DescentDevelopers#295.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants