Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve spdlog integration #248

Open
Lgt2x opened this issue Apr 30, 2024 · 3 comments
Open

Improve spdlog integration #248

Lgt2x opened this issue Apr 30, 2024 · 3 comments
Assignees
Labels
enhancement Something to modernize things wiki A contribution to the wiki

Comments

@Lgt2x
Copy link
Collaborator

Lgt2x commented Apr 30, 2024

Minimal spdlog support has been merged in #212 . For wider support in the game, we now need to:

  • Add developer doc in the wiki for usage
  • Add a command-line to output to file
  • Add CLI option to use it in Release mode ?
  • Convert most debug printf to using it
    More ?

@bryanperris @JeodC

@Lgt2x Lgt2x self-assigned this Apr 30, 2024
@bryanperris
Copy link
Contributor

bryanperris commented Apr 30, 2024

log levels info, error, warn should already be available in release builds. I do plan on replacing all those printf stuff with this logging system. Anything being printed to the terminal should now be captured by the log system instead.

I already plan to do more PRs that will start logging out more details of various things (eg: the level loading stuff should have trace prints)

Note: trace level logging should be ifdef'd out for release builds no matter what.

@winterheart
Copy link
Collaborator

winterheart commented Apr 30, 2024

I think we may make all logging levels available for users, as this may be useful for issue reporting.
Definitely we should create relevant CLI and config options both for log level and log file path.

@JeodC JeodC added enhancement Something to modernize things wiki A contribution to the wiki labels Apr 30, 2024
@JeodC
Copy link
Member

JeodC commented May 2, 2024

Related: #271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something to modernize things wiki A contribution to the wiki
Projects
None yet
Development

No branches or pull requests

4 participants