Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Runtime Issue]: Render effects missing #193

Open
JeodC opened this issue Apr 26, 2024 · 2 comments
Open

[Runtime Issue]: Render effects missing #193

JeodC opened this issue Apr 26, 2024 · 2 comments
Assignees
Labels
enhancement Something to modernize things request Request for a feature

Comments

@JeodC
Copy link
Member

JeodC commented Apr 26, 2024

Description

In Direct3D, some special rendering effects such as specular highlights, lighting, reflections etc are used, but in OpenGL they are missing. Images below show the differences. The first two images showcase the effects in Direct3D rendering. The final image showcases how the game renders in OpenGL.

image
image

image

Modern times call for modern solutions. Document what is happening here and, if possible, enable it on OpenGL, which should be able to handle all of this in the current year.

@JeodC JeodC added request Request for a feature enhancement Something to modernize things labels Apr 26, 2024
@JeodC
Copy link
Member Author

JeodC commented May 5, 2024

This was done via the -bumped CLI and would only work on the Direct3D renderer. Maybe it can be ported to OpenGL.

@jmarshall23 jmarshall23 self-assigned this May 6, 2024
@jmarshall23
Copy link

Already working finishing a version of this in my fork, I'll bring it over to mainline when its ready to go.

@JeodC JeodC changed the title [Runtime Issue]: Rendering effects missing [Runtime Issue]: Render effects missing May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something to modernize things request Request for a feature
Projects
None yet
Development

No branches or pull requests

2 participants