Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent line endings #129

Closed
Jayman2000 opened this issue Apr 21, 2024 · 2 comments
Closed

Inconsistent line endings #129

Jayman2000 opened this issue Apr 21, 2024 · 2 comments
Labels
needs testing Needs testing to confirm issue or resolution suggestion Suggestion open for discussion

Comments

@Jayman2000
Copy link
Contributor

Some files in this repo use LF line endings, and some files in this repo use CRLF line endings. I created a script that will calculate how many files use LF line endings and how many files use CRLF line endings. Here’s what the script says when you run it on the most recent commit (07d988e):

Total number of files that use LF line endings: 1,491 (86%)
Total number of files that use CRLF line endings: 62 (3%)
Total number of files: 1,724

It would be nice if all of the files in this repo used the same line endings. Are there any files that need to use LFs or need to use CRLFs? For example, I can see that scripts/data/linuxfullhog/d3i.str uses CRLFs. Would using LFs in that file break anything?

@JeodC JeodC added the suggestion Suggestion open for discussion label Apr 21, 2024
@GravisZro
Copy link
Contributor

GravisZro commented Apr 22, 2024

This is fixed in PR #151

@JeodC
Copy link
Member

JeodC commented Apr 25, 2024

It is simple to add a .gitattributes file to take care of this, but scripts may depend on CRLF endings to function. It would need to be tested on the other platforms.

@JeodC JeodC added the needs testing Needs testing to confirm issue or resolution label Apr 25, 2024
@JeodC JeodC closed this as completed May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs testing Needs testing to confirm issue or resolution suggestion Suggestion open for discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants