Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTK doesn't support xdg_decoration_unstable_v1 but does support org_kde_kwin_server_decoration_manager #52

Open
Fox2Code opened this issue Apr 2, 2024 · 3 comments

Comments

@Fox2Code
Copy link
Sponsor

Fox2Code commented Apr 2, 2024

This is very silly, GTK support KDE protocol for decoration, but not the XDG one.

Relevant code: https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gdk/wayland/gdkdisplay-wayland.c
Searching for xdg_decoration in the entire project result in nothing
Checking for org_kde_kwin_server_decoration_manager gives multiple results

Relevant protocols:

Since Louvre already support xdg_decoration_unstable_v1, supporting org_kde_kwin_server_decoration_manager as well shouldn't be much an issue as they are almost identical protocols.

@ehopperdietzel
Copy link
Member

It seems like it is deprecated and XDG Decoration should be preferred.

Wayland KDE Server Decoration Protocol

There have been discussions about replacing it in GTK.

GTK Merge Request

So I think it's a better idea to wait for GTK to support XDG decoration.

@Fox2Code
Copy link
Sponsor Author

Fox2Code commented Apr 3, 2024

@ehopperdietzel It may take literal years for this GTK MR to be included, and since the KDE Decoration protocol is deprecated, it is not longer subject to change, on the other hand I don't know if there is many GTK apps that uses server side decorations, as Gnome is popularly known to be against server side decorations.

@ehopperdietzel
Copy link
Member

I am going to consider it, but to be honest, I don't like the idea of adding two protocols for the same purpose, and even worse if one of those is deprecated. Anyway, GTK has a very robust theming system for CSD, which even allows applying border masks for round corners and such. So, in the meantime, that could be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants