-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reading of columns of type Tuple(Map(LowCardinality(...)))
#63956
Merged
hanfei1991
merged 1 commit into
ClickHouse:master
from
CurtizJ:fix-tuple-map-low-cardinality
May 27, 2024
Merged
Fix reading of columns of type Tuple(Map(LowCardinality(...)))
#63956
hanfei1991
merged 1 commit into
ClickHouse:master
from
CurtizJ:fix-tuple-map-low-cardinality
May 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll4
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
May 16, 2024
This is an automated comment for commit bb130f4 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
CurtizJ
force-pushed
the
fix-tuple-map-low-cardinality
branch
from
May 16, 2024 12:52
291d921
to
bb130f4
Compare
hanfei1991
reviewed
May 16, 2024
{ | ||
if (auto cached_column = getFromSubstreamsCache(cache, settings.path)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add some comments here? It's not easy to see where the bug is at first glance.
hanfei1991
approved these changes
May 27, 2024
Merged
via the queue into
ClickHouse:master
with commit May 27, 2024
5a35010
230 of 233 checks passed
robot-ch-test-poll3
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
May 27, 2024
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-bugfix
Pull request with bugfix, not backported by default
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed reading of columns of type
Tuple(Map(LowCardinality(String), String), ...)
Fixes #63863
Fixes #63859
Modify your CI run
NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step
Include tests (required builds will be added automatically):
Exclude tests:
Extra options:
Only specified batches in multi-batch jobs: