Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please, use SVG icons instead font icons #6362

Open
toby3d opened this issue Apr 29, 2024 · 1 comment
Open

Please, use SVG icons instead font icons #6362

toby3d opened this issue Apr 29, 2024 · 1 comment
Labels
Component: Player ⏯️ Status: Blocked ✋ Somehow, somewhere *else*, something has gone very wrong. Until they fix it we're stuck. Type: Feature Request ✨

Comments

@toby3d
Copy link

toby3d commented Apr 29, 2024

Describe the current behavior

At least the PeerTube player uses font icons instead of SVGs, which break down into "tofu" if you completely disable font loading on the browser side:
изображение

Steps to reproduce

Disable external fonts download in your browser by setting or uBlock Origin option.

Describe the expected behavior

SVG icons for pause/play, CC buttons and round scroller in timeline slider, as in any other buttons and elements of PeerTube interface.

Additional information

  • PeerTube instance:

  • Browser name, version and platforms on which you could reproduce the bug: Firefox Developer Edition v126.0b5

@Chocobozzz
Copy link
Owner

video.js 8.5 may allow us to use svg icons: https://github.com/videojs/video.js/blob/main/CHANGELOG.md#850-2023-06-12

But video.js upgrade to v8 is currently blocked by videojs/video.js#8242

@Chocobozzz Chocobozzz added the Status: Blocked ✋ Somehow, somewhere *else*, something has gone very wrong. Until they fix it we're stuck. label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Player ⏯️ Status: Blocked ✋ Somehow, somewhere *else*, something has gone very wrong. Until they fix it we're stuck. Type: Feature Request ✨
Projects
None yet
Development

No branches or pull requests

2 participants