Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine Ffmpeg commands into one single command (macOS) #24

Open
richiemcilroy opened this issue Apr 11, 2024 · 12 comments
Open

Combine Ffmpeg commands into one single command (macOS) #24

richiemcilroy opened this issue Apr 11, 2024 · 12 comments

Comments

@richiemcilroy
Copy link
Contributor

richiemcilroy commented Apr 11, 2024

Right now, there are two separate commands for capturing audio and video. They can be found in media.rs located in apps/desktop/src-tauri. I would like to have them combined into one single ffmpeg command to reduce system load when recording.

Requirements

  • Create one single ffmpeg command that takes input from both the audio and video sources, muxing into one .ts file
    • This will probably be done by creating separate named pipes as the input sources
  • Make sure the recording process is still performant after changing

You can use this guide to help you get started developing locally as quickly as possible.

@richiemcilroy
Copy link
Contributor Author

/bounty $100

Copy link

algora-pbc bot commented Apr 11, 2024

💎 $100 bounty • Cap

Steps to solve:

  1. Start working: Comment /attempt #24 with your implementation plan
  2. Submit work: Create a pull request including /claim #24 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to CapSoftware/Cap!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🔴 @webbdays Apr 11, 2024, 3:11:38 PM WIP

@webbdays
Copy link

webbdays commented Apr 11, 2024

/attempt

Algora profile Completed bounties Tech Active attempts Options
@webbdays 1 bounty from 1 project
Python, Rust,
JavaScript & more
Cancel attempt

@webbdays
Copy link

@richiemcilroy
some example usage of the command?

@richiemcilroy
Copy link
Contributor Author

@webbdays here's a link to where both of the separate commands are located;

https://github.com/CapSoftware/Cap/blob/main/apps/desktop/src-tauri/src/media.rs#L418

@webbdays
Copy link

yes, i would like to have idea of using command with both type of inputs.

@richiemcilroy
Copy link
Contributor Author

@webbdays it's possible but requires the use of fifo named pipes so that ffmpeg can read from the two input sources from one command.

Or if there's an alternative method with a better approach that can also be used.

@webbdays
Copy link

ok.

@webbdays
Copy link

webbdays commented Apr 11, 2024

Currently, i am not full-fledged working on this.
others with ideas can attempt this issue.

@ologbonowiwi
Copy link

Make sure the recording process is still performant after changing

do we have any sort of benchmark to run before and after?

@richiemcilroy
Copy link
Contributor Author

I guess the benchmark is just making sure that the screen capture and microphone recording is being created from a single ffmpeg command instead of two currently

@ologbonowiwi
Copy link

Where are recordings saved on the dev environment (without S3 enabled)?

Also, do I need a running mysql to run the app locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants