Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taskbar Accent Color for Both Modes #823

Open
0x1337F00D opened this issue Feb 22, 2024 · 8 comments
Open

Taskbar Accent Color for Both Modes #823

0x1337F00D opened this issue Feb 22, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@0x1337F00D
Copy link

Describe the enhancement or feature you'd like

Currently, we can only use the taskbar accent color either in light or dark mode.
I would like to have it enabled for both by adding a third option "Both" or similar.
Should be a simple thing, but before creating a PR myself, I'd rather collect some opinions here first.

Describe alternatives you've considered

Currently I switch manually. My primary motivation is to have a white font on the taskbar at all times while still having a light/dark mode in general. My wallpaper is quite dark, that's why :)

Additional context

image

@0x1337F00D 0x1337F00D added the enhancement New feature or request label Feb 22, 2024
@Spiritreader
Copy link
Member

I'm not sure if windows can do this.

Can you provide some instructions how to set it up with the windows control pabel? We can only mimic what's possible there.

@0x1337F00D
Copy link
Author

Thanks for responding. For my scenario, when my PC switches to dark mode automatically, I click the "Use Taskbar Accent Color during Dark Theme", same goes for when it switches to bright again. I want to automate that, when the theme switches.

Simply put, I want to remove the mutual exclusivity of these buttons so that the underlying action (happening when you click the radiobutton) is executed automatically with theme switch. It would be more consistent and logical in my understanding :)

Mockup:
image

@Armin2208
Copy link
Member

The checkboxes are a great idea!

@Armin2208
Copy link
Member

Maybe it's not a good idea to have Accent Color during light theme at all. Because tray icons of third party applications appear dark, which isn't a great experience.
grafik

@0x1337F00D
Copy link
Author

Thanks for your feedback. I don't know about the black icons thing, but thats outside of the scope ADM. With the checkboxes, you can at least decide for yourself. I will see if I have the time to make a prototype and create a PR.

@0x1337F00D
Copy link
Author

Unfortunately, I cannot even get the cloned project to build in VS Code, I just build two DLL files. I'd be grateful for any help @Armin2208 ;)

@Armin2208
Copy link
Member

Unfortunately, I cannot even get the cloned project to build in VS Code, I just build two DLL files. I'd be grateful for any help @Armin2208 ;)

you need to have git installed to build the project. Also we don't use VS Code, we use VS.

@Spiritreader
Copy link
Member

Spiritreader commented Mar 10, 2024

Thanks for responding. For my scenario, when my PC switches to dark mode automatically, I click the "Use Taskbar Accent Color during Dark Theme", same goes for when it switches to bright again. I want to automate that, when the theme switches.

Simply put, I want to remove the mutual exclusivity of these buttons so that the underlying action (happening when you click the radiobutton) is executed automatically with theme switch. It would be more consistent and logical in my understanding :)

Mockup: image

I'm not really sure what adding two checkboxes here would accomplish?
It doesn't really solve the problem you're describing.
It wouldn't let you have a white font at all times. It just switches the accent color on/off.

If you want to have a white font at all times, you would neet to set the System theme to dark, but then also other components like the start menu will remain in dark mode, with no way to change it.

If you are able to reproduce the behavior you want by using only the Windows settings page and the registry, we can take a look at possibly integrating this.
But I currently don't see how ADM can help you here and I want to avoid you putting in the work for a PR that ends up not getting accepted.

If you just want the accent color to stay enabled in all modes, we would need to revert the logic that follows windows. That is certainly possible, but the correct way to then solve this would be by putting an extra check box that explicitly disabled Windows' own native behavior in favor for the one you want.
The reason for this is that by allowing two checkboxes ADM would be responsible for explicitly not switching something, which adds maintenance work for us and is kind of backwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants