Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Use NanaZip fork instead of 7-Zip #1021

Open
agowa opened this issue Jan 18, 2024 · 25 comments
Open

[FEATURE] - Use NanaZip fork instead of 7-Zip #1021

agowa opened this issue Jan 18, 2024 · 25 comments
Labels
enhancement New feature or request fixed next release Where next release will have the issue fixed

Comments

@agowa
Copy link

agowa commented Jan 18, 2024

What is your feature request regarding to?

Atlas Playbook

Is your feature request related to a problem? Please describe.

Consider using the NanaZip fork of 7-Zip instead of 7-Zip itself as it has better integration into windows 11.
E.g. not needing to modify the path environment variable in order to use 7z.exe from the cli (because of it registering itself within "Apps > Advanced app settings > App execution aliases").

Describe the solution you would like.

Instead of installing 7-Zip through the playbook install NanaZip

Describe alternatives you have considered.

does not apply

Additional context.

No response

@agowa agowa added the enhancement New feature or request label Jan 18, 2024
@n00b69
Copy link

n00b69 commented Jan 18, 2024

+1

Also, not sure if still applicable, but in the past Nanazip Preview worked better on win11 than the regular one. I have only ever used the Preview version, so I cannot confirm this.

@Revival8697
Copy link

-1

Consider to NOT use NanaZip till a stable release is out.

@JayXTQ
Copy link
Member

JayXTQ commented Jan 18, 2024

let's not have a debate about this topic. if there is no stable release, this issue will be put on hold until there is a stable release. closing for now until then.

@JayXTQ JayXTQ closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2024
@agowa
Copy link
Author

agowa commented Jan 19, 2024

@JayXTQ But there is a stable release https://apps.microsoft.com/detail/9N8G7TSCL18R?hl=en-us&gl=US

@JayXTQ
Copy link
Member

JayXTQ commented Jan 19, 2024

just because it's on ms store doesn't mean it's stable lol. until there is valid evidence that it is stable this will be closed. or if it's not needed in atlas, which it isn't really as 7z works fine

@agowa
Copy link
Author

agowa commented Jan 19, 2024

7z is neither added to the path, nor does it register itself for an app execution alias, so "7z works fine" is debatable.
Also NanaZip has a bunch of improvements just look at the list either on the store page or their GitHub. Like it supporting additional compression algorithms, archive types, better dpi awareness for multi monitor setups, additional hashing algorithms, improved security, ...

Also what do you want as "prove" that it isn't unstable if this isn't enough?:
This is the stable version: https://apps.microsoft.com/detail/9N8G7TSCL18R?hl=en-us&gl=US
And this is the preview version: https://apps.microsoft.com/detail/9NZL0LRP1BNL?hl=en-us&gl=US
And this is the projects GitHub page: https://github.com/M2Team/NanaZip

@JayXTQ
Copy link
Member

JayXTQ commented Jan 19, 2024

none of those benefits are needed in atlas and it doesn't need to be added to path for it to work for the average user. you forget this is not something for developers but for gamers.

@Revival8697
Copy link

Revival8697 commented Jan 19, 2024

But there is a stable release

improved security

M2Team/NanaZip#330, M2Team/NanaZip#331. The stable build of NanaZip is severely outdated.

Also what do you want as "prove" that it isn't unstable if this isn't enough?

v3 is in Preview, we shouldn't ship Preview/Beta/Unstable builds to users.

@Ast3risk-ops
Copy link

I had no idea about those and I used the stable build of nanazip when on windows 💀

@agowa
Copy link
Author

agowa commented Jan 20, 2024

Same, wasn't aware of these ones.

@francisco-lafe
Copy link

I'm not sure I'm understanding why NanaZip 2.0 (stable) is not being considered as an option.

@Ast3risk-ops
Copy link

I'm not sure I'm understanding why NanaZip 2.0 (stable) is not being considered as an option.

Security issues and it's not actually stable and 7zip works just fine.

@he3als he3als added the proposal This is put forwarded for consideration label Jan 24, 2024
@he3als he3als reopened this Jan 24, 2024
@he3als
Copy link
Member

he3als commented Jan 24, 2024

You can argue security issues, but 7-Zip doesn't automatically update or notify the users of updates. Once NanaZip gets more developed, it should be fundamentally more secure, as NanaZip is installed and updated via the Store.

Currently though, I don't think that NanaZip is in a developed enough state to make it worth using over 7-Zip, and the process of automatic installation inside the playbook will be a bit more difficult due to it being AppX.

I'll keep this open to track it's development.

@he3als
Copy link
Member

he3als commented Jun 6, 2024

I've checked up on the project again and I'm happy to implement NanaZip. The only issue is that there's no permanent download links to the latest release (appx and license), and we can't use the GitHub API to get this as its blocked in certain regions.

@Ast3risk-ops
Copy link

Ast3risk-ops commented Jun 6, 2024

I've checked up on the project again and I'm happy to implement NanaZip. The only issue is that there's no permanent download links to the latest release (appx and license), and we can't use the GitHub API to get this as its blocked in certain regions.

There's the Microsoft store, fetch it from there via winget.

For stable builds you can use https://sourceforge.net/projects/nanazip/files/latest/download

@he3als
Copy link
Member

he3als commented Jun 6, 2024

WinGet seemingly has a chance of not being installed/updated on some installs for some reason. Therefore, we'd need a WinGet install script, and quite a lot can go wrong there. I already tried this before.

I think SourceForge is also blocked in some countries.

@Ast3risk-ops
Copy link

Ast3risk-ops commented Jun 6, 2024

Can't win 'em all. Try using the GitHub API to do it, then if it's blocked switch to 7zip.

@he3als
Copy link
Member

he3als commented Jun 6, 2024

Sure.

@he3als he3als added help wanted Extra attention is needed planned To be done in future. and removed proposal This is put forwarded for consideration labels Jun 6, 2024
@Ast3risk-ops
Copy link

Sure.

Great backup in case of an API rate limit too 😬

@he3als he3als added fixed next release Where next release will have the issue fixed and removed help wanted Extra attention is needed planned To be done in future. labels Jun 6, 2024
@JayXTQ
Copy link
Member

JayXTQ commented Jun 7, 2024

@he3als use jsdelivr

@he3als
Copy link
Member

he3als commented Jun 7, 2024

You can't use the GitHub API with JSDelivr, or download releases without asking them

@JayXTQ
Copy link
Member

JayXTQ commented Jun 7, 2024

I know you can't use the GitHub API, but can't you use JSDelivr to download a release?

@JayXTQ
Copy link
Member

JayXTQ commented Jun 7, 2024

Also, they do have sourceforge, but no clue if available in all regions: https://sourceforge.net/projects/nanazip/

@he3als
Copy link
Member

he3als commented Jun 7, 2024

can't you use JSDelivr to download a release

If I recall correctly, no, unless you request them to set up a proxy for the repositories' releases. However, the GitHub API is required to get the download link first; without that, we can't get the latest release URL.

If we have a way to get a list of the latest releases using JSDelivr, that could work.

they do have sourceforge, but no clue if available in all regions

I don't think it is, unfortunately.

@he3als
Copy link
Member

he3als commented Jun 7, 2024

I’ve implemented it currently so that if NanaZip isn’t accessible, it gets 7-Zip instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed next release Where next release will have the issue fixed
Projects
None yet
Development

No branches or pull requests

7 participants