Fix bug with Safari #1386
Open
Fix bug with Safari #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! As I do not own any Apple device I was not able to find a solution to this issue. Your fix has an undesirable side effect though: the header hides the scrollbar. Without the fix With the fix |
|
I see that. Do you have any suggestions for how to solve this issue then? I'm happy to test anything and everything that you can think of. Alternatively, when the website is added to the Home Screen as an app (as I have it, and I'm sure others), pull-to-refresh is automatically disabled, and so the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1168 by allowing the root element to be scrollable. Simple fix, just let
#rootoverflow as needed and things seem to work fine.Tested on macOS Safari as well as iPhone Safari.
Caused by
in
/commafeed-client/src/main.css. Bug only occurs when the sidebar is scrollable.