Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] support structured logging #2890

Open
4 tasks
axiomofjoy opened this issue Apr 13, 2024 · 1 comment
Open
4 tasks

[ENHANCEMENT] support structured logging #2890

axiomofjoy opened this issue Apr 13, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@axiomofjoy
Copy link
Contributor

axiomofjoy commented Apr 13, 2024

Phoenix is no longer just a library, but is also a containerized application. We should update our logging accordingly.

  • Add a setting that can be configured by an environment variable that will configure structured logs for Phoenix. By default, no non-standard logging configuration will be used so that Phoenix continues to act as usual when used as a library (e.g., in a notebook environment).
  • Add a JSON formatter.
  • Log off the main thread with QueueHandler.
  • Use UTC timestamps.

Helpful introduction to Python logging: guide on modern Python logging.

@axiomofjoy axiomofjoy added enhancement New feature or request triage issues that need triage labels Apr 13, 2024
@dosubot dosubot bot added the c/server Server implementation label Apr 13, 2024
@axiomofjoy axiomofjoy changed the title [ENHANCEMENT] improve logging [ENHANCEMENT] support structured logging Apr 13, 2024
@axiomofjoy axiomofjoy removed c/server Server implementation triage issues that need triage labels Apr 14, 2024
@axiomofjoy axiomofjoy self-assigned this Apr 15, 2024
@axiomofjoy
Copy link
Contributor Author

Unscheduling this one and closing the PR for now. We can revisit when it becomes relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📘 Todo
Development

Successfully merging a pull request may close this issue.

1 participant