Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Not all threads terminate prior to main when executing certain unit tests #2245

Open
icmccorm opened this issue Dec 11, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@icmccorm
Copy link

馃悰 Bug Report

I've been developing an experimental version of Miri that can execute foreign functions by interpreting LLVM bytecode. I was testing it on this crate, and it didn't find any borrowing violations, but Miri did report that several threads were still running after the main thread terminated.

Steps to Reproduce

The custom version of Miri that I'm using is public, but to use it, you'll need to build Rust from source. If you take this route, the following command will reproduce the error:

MIRIFLAGS="-Zmiri-llvm-read-uninit" cargo miri test -- [test_name]

Here's the error message I see:

error: the main thread terminated without waiting for all remaining threads

This occurs for the following tests:

  • fft::domain::tests::test_roots_of_unity
  • fft::polynomial::dense::tests::double_polynomials_random
  • fft::polynomial::dense::tests::evaluate_polynomials
  • fft::polynomial::dense::tests::sub_polynomials
  • fft::tests::test_roots_of_unity
  • snark::marlin::ahp::ahp::tests::test_summation

Expected Behavior

All other threads should terminate prior to the main thread.

Your Environment

  • snarkvm-algorithms 0.14.6
  • rustc nightly-2023-09-25
  • Amazon Linux (x86)
@icmccorm icmccorm added the bug Something isn't working label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant