Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Amend superfluous is_peer_far_in_future check #3168

Open
vicsn opened this issue Mar 12, 2024 · 0 comments
Open

[Feature] Amend superfluous is_peer_far_in_future check #3168

vicsn opened this issue Mar 12, 2024 · 0 comments
Assignees
Labels
feature New feature or request

Comments

@vicsn
Copy link
Contributor

vicsn commented Mar 12, 2024

馃殌 Feature

is_peer_far_in_future seems not to do anything, because down the call chain into update_to_next_round , we need to see quorum anyway and we're only advancing one round at a time?. So we can consider not advancing at all when is_peer_far_in_future` and removing that variable.

@vicsn vicsn added the feature New feature or request label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants