Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Ensure validators only participate in peer gossip when feature flag is set #3155

Open
vicsn opened this issue Mar 5, 2024 · 0 comments
Assignees
Labels
feature New feature or request

Comments

@vicsn
Copy link
Contributor

vicsn commented Mar 5, 2024

馃殌 Feature

In order to enhance the robustness of a validator node, we should by default ensure they only accept connections from trusted clients. Given that we already have a --peers flag to specify peers, I propose we only have to add:

      --allow-outside-peers
                If the flag is set, the validator will engage in P2P gossip to request more peers.

Implementation

If the --allow-outside-peers flag is not set, a validator should not send out any PeerRequest nor accept PeerResponse. We may need to take into account that trusted peers are not dropped/shuffled.

For clients, there is no difference in behavior.

@vicsn vicsn added the feature New feature or request label Mar 5, 2024
@vicsn vicsn changed the title [Feature] Add validator feature flag which ensures only chosen clients can connect to it [Feature] Ensure validators only participate in peer gossip when feature flag is set Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants