Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AGE-164] [Improvement] Speed up the endpoint /get_config #1599

Closed
mmabrouk opened this issue May 2, 2024 · 0 comments · Fixed by #1639
Closed

[AGE-164] [Improvement] Speed up the endpoint /get_config #1599

mmabrouk opened this issue May 2, 2024 · 0 comments · Fixed by #1639
Assignees
Labels
3 points Created by Linear-GitHub Sync High Priority improvement
Milestone

Comments

@mmabrouk
Copy link
Member

mmabrouk commented May 2, 2024

The call to retrieve the configuration takes 1.20 seconds, indicating that 'get_config' is highly unoptimised.

Here's the current process:

  • It fetches the base_id.
  • It checks permissions.
  • It lists the environment for the app_id, which is obtained from the base_id.
  • It searches one by one until it finds the correct name.
  • It gets the variant_revision_id from the found environment.
  • It returns the configuration from that variant.

This process involves a significant number of queries!

From SyncLinear.com | AGE-164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 points Created by Linear-GitHub Sync High Priority improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants