Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring removed critical / necessary code #89

Open
tkreuder opened this issue May 5, 2024 · 5 comments
Open

Refactoring removed critical / necessary code #89

tkreuder opened this issue May 5, 2024 · 5 comments
Labels
sweep Sweep your software chores

Comments

@tkreuder
Copy link

tkreuder commented May 5, 2024

Details

23a217d removed code, so that pinecone export does not work anymore

Branch

No response

@tkreuder tkreuder added the sweep Sweep your software chores label May 5, 2024
Copy link

greptile-apps bot commented May 5, 2024

To address the issue with Pinecone export functionality not working due to code removal in the commit 23a217dd5c8717536260bef842064222621fcb15, please review the current implementation of the ExportPinecone class in src/vdf_io/export_vdf/pinecone_export.py. This file contains the necessary methods for exporting data from Pinecone, including initialization, data fetching, and saving to a parquet file. If the removed code is critical for the operation, consider reverting the changes or re-implementing the missing functionality based on the current structure of the ExportPinecone class and its methods. Additionally, examining the src/vdf_io/export_vdf directory may provide insights into how export functionalities are structured across different databases, which could be helpful in restoring or enhancing the Pinecone export feature.

References

ai-northstar-tech/vector-io/src/vdf_io/export_vdf/pinecone_export.py
ai-northstar-tech/vector-io/src/vdf_io/export_vdf

Ask Greptile

@dhruv-anand-aintech
Copy link
Member

Hi @tkreuder, this commit was part of a PR #86 which added back the necessary code under a flag. If the new list() function fails to list the ids in the index, it uses the old random search method to get the points. Can you share the command you use to export, the verson of vecto-io you used, and the error you got?

@dhruv-anand-aintech
Copy link
Member

I'm looking into the issue further and it looks like the function update_range_from_new_ids didn't get added back. testing a fix now

@dhruv-anand-aintech
Copy link
Member

can you retry with 0.1.246?

And if it doesn't work, try again using the flag --no-use_list_points after pinecone in your command

@dhruv-anand-aintech
Copy link
Member

@tkreuder could you confirm if this fixed it for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep Sweep your software chores
Projects
None yet
Development

No branches or pull requests

2 participants