Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: agent-protocol command #17

Open
jzanecook opened this issue Aug 1, 2023 · 0 comments
Open

Discussion: agent-protocol command #17

jzanecook opened this issue Aug 1, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jzanecook
Copy link
Collaborator

I think this is good DX. Ultimately I don't think it matters if you need to run pip install or npm i (we might want to have brew installation in the future). The point is that you can now just run agent-protocol and it'll work without anything else.

With the npx tool, we could also instruct users to use npx agent-protocol test --url <url> [...] as well as running npm i and then running it. Speaking of brew, I think we could easily get something running on the Debian/Choco/Arch repositories as well if you wanted to head in that direction.


As far as the design of the agent-protocol command, if I'm not mistaken right now we're only looking at a single command test with the argument --url,-u <url> to run the compliance on, and no other settings, correct? (Besides I would assume, a standard --version,-v and --help,-h)

I talked about using commander.js rather than click, but for the testing is there a specific js testing framework you like to use? If I look up "best alternative to pytest for javascript" I did come across Jasmine but I'm not sure if you wanted to go with that or something more used like Mocha or Jest. I went ahead and made a github comparison, and it looks like Jest takes the cake as far as popularity goes.

For the requests in the test I'll likely use the built-in fetch unless you have an axios preference.

Does that cover all the bases? Am I missing anything?

@jakubno jakubno added enhancement New feature or request good first issue Good for newcomers labels Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants